D25432: Fix HTTP proxy settings

dfaure added a comment. Done in https://commits.kde.org/kio/48b8cab8da5e264f233d59cf2aff2b981255f6bf Please check if other places are affected. This code could be simplified by using `configValue()` instead, no? Right now the QString() argument serves no purpose, it gets converted to

D25432: Fix HTTP proxy settings

dfaure added a comment. This doesn't appear to fix the bug for me. I get a stringlist with one empty string in it, which goes to the "else" branch on line 2712. This is very probably the reason for the ftp and http tests being broken in CI too. I'll a SkipEmptyParts to the split(), but

D25432: Fix HTTP proxy settings

meven added a comment. In D25432#565595 , @trufanov wrote: > Hmm, I've just `git grep` the repo and found another place that is most probably affected by the same problem in FTP slave; > https://github.com/KDE/kio/blob/d03551cd0367ac7760224c5

D25432: Fix HTTP proxy settings

trufanov added a comment. Hmm, I've just `git grep` the repo and found another place that is most probably affected by the same problem in FTP slave; https://github.com/KDE/kio/blob/d03551cd0367ac7760224c56bda943c937ba5dac/src/ioslaves/ftp/ftp.cpp#L320 Could you check out if it's a QVa

D25432: Fix HTTP proxy settings

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c0ae03d14b0e: Fix HTTP proxy settings (authored by trufanov). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25432?vs=70084&id=70098 REVISION DETAIL https://phabrica

D25432: Fix HTTP proxy settings

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Thank you for digging it ! KConfig did quite some work `KConfigGroupPrivate::deserializeList` https://cgit.kde.org/kconfig.git/tree/src/core/kconfiggroup.cpp#n155 But a simple `toSt

D25432: Fix HTTP proxy settings

meven edited the summary of this revision. meven added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25432 To: trufanov, meven, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25432: Fix HTTP proxy settings

trufanov created this revision. trufanov added a reviewer: meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. trufanov requested review of this revision. REVISION SUMMARY After latest libKF5KIOCore.so.5.65.0 update my KTorrent has stopped to work via HTT