D25401: Fix deprecation syntax in ktcpsocket.h

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25401 To: dfaure, vkrause, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25401: Fix deprecation syntax in ktcpsocket.h

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25401 To: dfaure, vkrause, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25401: Fix deprecation syntax in ktcpsocket.h

dfaure added a comment. Oops, local patch! (to add some debugging code in case of timeout). OK, that brown-paper-bag issue aside, the reasoning about deprecating classes remains :-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25401 To: dfaure, vkrause, kosseba

D25401: Fix deprecation syntax in ktcpsocket.h

vkrause added a comment. In D25401#564683 , @dfaure wrote: > As a data point: this commit changes things for kimap, which has code saying > > src/imapstreamparser.cpp:493:} else if (KTcpSocket *socket = qobject_cast(m_socket)) {

D25401: Fix deprecation syntax in ktcpsocket.h

dfaure added a comment. As a data point: this commit changes things for kimap, which has code saying src/imapstreamparser.cpp:493:} else if (KTcpSocket *socket = qobject_cast(m_socket)) { src/imapstreamparser.cpp-494-qWarning() << "No incoming packet for

D25401: Fix deprecation syntax in ktcpsocket.h

kossebau added a comment. One thing I saw with the Qt deprecation tags is that deprecation attributes were only added to constructor calls, not the class itself. Which to me made some sense, as one should be warned when creating instances of that class. But once you are passed an instance d

D25401: Fix deprecation syntax in ktcpsocket.h

dfaure created this revision. dfaure added reviewers: vkrause, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY gcc (7.4.1 here) says: ktcpsocket.h:171:22: warning: attribute ignored in dec