D25244: Implement ISpellChecker backend for Windows >= 8

cullmann added a comment. This allows to shrink e.g. the Kate installation on Windows from 431 MB to 274 MB, > 150 MB space less occupied ;=) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: mludwig, kde-frameworks-devel, L

D25244: Implement ISpellChecker backend for Windows >= 8

This revision was automatically updated to reflect the committed changes. cullmann marked an inline comment as done. Closed by commit R246:67cbe8776a1f: Implement ISpellChecker backend for Windows >= 8 (authored by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricat

D25244: Implement ISpellChecker backend for Windows >= 8

vonreth accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH sonnet_ispellchecker_win REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngrah

D25244: Implement ISpellChecker backend for Windows >= 8

cullmann marked 2 inline comments as done. cullmann added inline comments. INLINE COMMENTS > vonreth wrote in ispellcheckerclient.cpp:33 > is that needed? It should be handled by the qt main loop? The docs state one shall do that in any case and that it stacks. I think there is no harm to do it,

D25244: Implement ISpellChecker backend for Windows >= 8

vonreth added inline comments. INLINE COMMENTS > ispellcheckerclient.cpp:33 > +// init com if needed > +m_wasCOMInitialized = SUCCEEDED(CoInitializeEx(nullptr, > COINIT_MULTITHREADED)); > + is that needed? It should be handled by the qt main loop? > ispellcheckerclient.cpp:59 > +//

D25244: Implement ISpellChecker backend for Windows >= 8

cullmann added a comment. Then we can merge this, or? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

mludwig added a comment. I've tried it out and works just fine! :) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

cullmann added a comment. Ok, thank you! REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

mludwig added a comment. In D25244#562817 , @cullmann wrote: > Some feedback? > Else I would just try that. > For me it worked fine (obviously). I will try it out over the weekend. It's something I planned to work on myself, but you

D25244: Implement ISpellChecker backend for Windows >= 8

cullmann added a comment. Some feedback? Else I would just try that. For me it worked fine (obviously). REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

cullmann added reviewers: Frameworks, vonreth. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY Provide ISpellChecker backend for Sonnet on Windows This avoids to ship all the hunspell dictionaries for Windows.