D25189: Add an overlay component for item activity feedback

2019-11-07 Thread Dan Leinir Turthra Jensen
leinir added inline comments. INLINE COMMENTS > ngraham wrote in FeedbackOverlay.qml:63 > Bonus points for showing a link that actually takes you to > https://bugs.kde.org/enter_bug.cgi?product=frameworks-knewstuff when this > error condition is present Couple of places where that wants to hap

D25189: Add an overlay component for item activity feedback

2019-11-07 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R304:24ffb9cb9c11: Add an overlay component for item activity feedback (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25189?vs=69384&id=69391 RE

D25189: Add an overlay component for item activity feedback

2019-11-07 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Good stuff. INLINE COMMENTS > FeedbackOverlay.qml:63 > +} else { > +statusLabel.text = i18nc("Label for the busy indicator > which should only be show

D25189: Add an overlay component for item activity feedback

2019-11-07 Thread Dan Leinir Turthra Jensen
leinir edited the test plan for this revision. leinir added reviewers: KNewStuff, Frameworks, Plasma, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25189 To: leinir, #knewstuff, #frameworks, #plasma, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michael

D25189: Add an overlay component for item activity feedback

2019-11-07 Thread Dan Leinir Turthra Jensen
leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This is the very first steps toward allowing for better, more involved feedback on what is happening with the items (suc