D25084: Allow a Multiple instances to become Unique

tcanabrava added a comment. > I'm open to counter-arguments and counter-examples. Actually, do we know of any other app than konsole which supports both Multiple and Unique modes? I would prefer to have only one mode. Tab & Split drag 'n drop only work in Single Instances, so if so

D25084: Allow a Multiple instances to become Unique

dfaure added a comment. > Just speculating, if an app opens as multiple and then another instance tries to open as unique, it should reuse the existing one or merge? With a konsole state of mind, I can see how this would possibly make sense indeed. But it would break DBus-activation of

Re: D25084: Allow a Multiple instances to become Unique

Point taken, I’ll rework the patch for a regexp of servicenane + ‘-‘ + pid, this will fix your second point. About your first point, do you think it’s a problem? Just speculating, if an app opens as multiple and then another instance tries to open as unique, it should reuse the existing one or mer

Re: D25084: Allow a Multiple instances to become Unique

im Open to redo the patch but I don’t see the problems you guys see. The only thing this patch does is to quit early if you trigger a unique application *after* a multiple one has been spawned. See: Konsole (register as multiple) Konsole —new-tab (register as single) But instead of adding a tab t

D25084: Allow a Multiple instances to become Unique

tcanabrava added a comment. Point taken, I’ll rework the patch for a regexp of servicenane + ‘-‘ + pid, this will fix your second point. About your first point, do you think it’s a problem? Just speculating, if an app opens as multiple and then another instance tries to open as uniqu

D25084: Allow a Multiple instances to become Unique

dfaure added a comment. If I read the patch correctly, then running a multi-instance app (`konsole-1234`) and then running it as unique will lead to `konsole-1234` instead of the expected `konsole`. Worse, if there was a completely unrelated `konsolesettings` application running, then kons

D25084: Allow a Multiple instances to become Unique

tcanabrava added a comment. im Open to redo the patch but I don’t see the problems you guys see. The only thing this patch does is to quit early if you trigger a unique application *after* a multiple one has been spawned. See: Konsole (register as multiple) Konsole —new-tab (regist

D25084: Allow a Multiple instances to become Unique

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Same reservations as davidedmundson. Furthermore this would break talking to dbus-activated unique apps, too, since they wouldn't register with the expected service name. -2 fr

Re: D25084: Allow a Multiple instances to become Unique

https://invent.kde.org/kde/konsole/merge_requests/45 But it’s not related to this path, it’s just another bug On Fri, 1 Nov 2019 at 07:06 David Edmundson wrote: > davidedmundson added a comment. View Revision > > > I think I just need to verify if the name

D25084: Allow a Multiple instances to become Unique

tcanabrava added a subscriber: GB_2. tcanabrava added a comment. https://invent.kde.org/kde/konsole/merge_requests/45 But it’s not related to this path, it’s just another bug REPOSITORY R271 KDBusAddons BRANCH multiple_to_unique REVISION DETAIL https://phabricator.kde.org/D25084

D25084: Allow a Multiple instances to become Unique

davidedmundson added a comment. > I think I just need to verify if the name would be the same as the name minus the uuid. because if you open an app on ::Multiple and later the same app on ::Unique, merging them seems sane. Could you link your konsole patch, I don't yet see why we would

D25084: Allow a Multiple instances to become Unique

tcanabrava added a comment. Yes, that's exactly what would happen, I think I just need to verify if the name would be the same as the name minus the uuid. because if you open an app on ::Multiple and later the same app on ::Unique, merging them seems sane. REPOSITORY R271 KDBusAddons BRAN

D25084: Allow a Multiple instances to become Unique

adridg added a comment. Now you (@davidedmundson ) mention it, yeah .. I've only tested positively, to see if konsole then does what I want. You're right that this could have surprising effects when multiple unique applications share a prefix (e.g. org.kde.plasma.something and org.kde.plasma

D25084: Allow a Multiple instances to become Unique

davidedmundson added a comment. I don't follow this patch. Say I'm starting a unique app (like org.kde.PlasmaShell) If another bus name already exists, which with the same prefix (such as "org.kde.PlasmaShellasdfasdf") then my new unique app will try to register as "org.kde.PlasmaSh

D25084: Allow a Multiple instances to become Unique

adridg accepted this revision. adridg added a comment. This revision is now accepted and ready to land. This has been applied to FreeBSD ports because it works. +1 (with the other konsole patch that **is** on invent). REPOSITORY R271 KDBusAddons BRANCH multiple_to_unique REVISION DETAIL

D25084: Allow a Multiple instances to become Unique

ngraham added a comment. Put this on invent maybe? REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D25084 To: tcanabrava Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25084: Allow a Multiple instances to become Unique

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY This fixes an issue with konsole when launched as Multiple Applications but once you typed --new-tab (that force