This revision was automatically updated to reflect the committed changes.
kossebau marked 2 inline comments as done.
Closed by commit R263:415402081d92: Add KAboutPluginDialog, to be used with
KPluginMetaData (authored by kossebau).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D25058?vs=
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kaboutapplicationdialog.cpp:72
> q->setWindowTitle(i18n("About %1", aboutData.displayName()));
> q->setModal(false);
>
(this line does nothing, dialogs aren
kossebau updated this revision to Diff 70052.
kossebau marked 2 inline comments as done.
kossebau added a comment.
Update to first review by @dfaure
REPOSITORY
R263 KXmlGui
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25058?vs=69002&id=70052
BRANCH
addaboutplugindialog
REVIS
kossebau marked 3 inline comments as done.
kossebau added inline comments.
INLINE COMMENTS
> dfaure wrote in kaboutplugindialog.cpp:119
> (I'm surprised by the explicit '&' in all those labels, doesn't
> KAcceleratorManager take care of this automatically?)
Seems it does. So removing then while
dfaure added a comment.
Nice work.
INLINE COMMENTS
> kaboutplugindialog.cpp:119
> +QWidget *translatorWidget =
> createTranslatorsWidget(pluginMetaData.translators(), QString(), q);
> +tabWidget->addTab(translatorWidget, i18n("T&ranslation"));
> +}
(I'm surprised by the
kossebau added a dependent revision: D25063: Deprecate
KAboutData::fromPluginMetaData, now there is KAboutPluginDialog.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D25058
To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngr
kossebau added a dependent revision: D25059: KPluginSelector: use new
KAboutPluginDialog.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D25058
To: kossebau, #frameworks, apol, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
kossebau created this revision.
kossebau added reviewers: Frameworks, apol, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.
REVISION SUMMARY
When showing an About dialog for a plugin, so far a
KAboutApplic
