aacid closed this revision.
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D24902
To: aacid, vkrause
Cc: kde-frameworks-devel, apol, dfaure, LeGast00n, GB_2, michaelh, ngraham,
bruns
dfaure added inline comments.
INLINE COMMENTS
> k7zip.cpp:1678
>
> QByteArray inflated;
> for (const QByteArray& data : qAsConst(inflatedDatas)) {
This makes me realize that there could be an inflated.reserve(unpackSize) here,
then, to avoid reallocations.
REPOSITORY
R243
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R243 KArchive
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24902
To: aacid, vkrause
Cc: kde-frameworks-devel, apol, dfaure, LeGast00n, GB_2, michaelh, ngraham,
bruns
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.
REVISION SUMMARY
oss-fuzz has created a file in which inflated size was smaller than
unpackSize and thus crc32 was using wrong memory
oss-
