This revision was automatically updated to reflect the committed changes.
Closed by commit R278:7dc38306b5b6: Use ECMGenerateExportHeader to manage
deprecated API better (authored by kossebau).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D24465?vs=67718&id=67921#toc
REPOSITORY
R278 K
zzag accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R278 KWindowSystem
BRANCH
useECMGenerateExportHeader
REVISION DETAIL
https://phabricator.kde.org/D24465
To: kossebau, #frameworks, #kwin, dfaure, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michae
dfaure added a comment.
+1 from me
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D24465
To: kossebau, #frameworks, #kwin, dfaure, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
kossebau updated this revision to Diff 67718.
kossebau added a comment.
fix incompleteness of patch WRT to NET::Override
While that flag is deprecated for clients, window managing code seems to
still need to handle that flag if set by old clients, so tagging it as
deprecated might resu
kossebau added inline comments.
INLINE COMMENTS
> zzag wrote in netwm_def.h:336-339
> This one should be wrapped in `#if KWINDOWSYSTEM_ENABLE_DEPRECATED_SINCE(5,
> 0)`, right?
Hmm... I should have checked the patch after uploading. IIRC I initially had
this guarded here, same with the Override
zzag added inline comments.
INLINE COMMENTS
> netwm_def.h:336-339
> /**
> @deprecated has unclear meaning and is KDE-only
> **/
> Override = 6, // NON STANDARD
This one should be wrapped in `#if KWINDOWSYSTEM_ENABLE_DEPRECATED_SINCE(5,
0)`, right?
REP
kossebau added a comment.
If no-one objects, would be pushing on Monday evening, Oct. 14th.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D24465
To: kossebau, #frameworks, #kwin, dfaure, zzag
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
kossebau created this revision.
kossebau added reviewers: Frameworks, KWin, dfaure, zzag.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.
REVISION SUMMARY
Allows
- projects linking to KWindowSystem to hide depr
