aacid closed this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D24403
To: aacid, cullmann, dhaumann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,
domson, michaelh, ngraham, bruns, demsking, sars
aacid requested review of this revision.
aacid added a comment.
This revision is now accepted and ready to land.
Ok, i'll commit it then :)
INLINE COMMENTS
> cullmann wrote in modebase.cpp:333
> Hmm, given that is a local var on the stack, I don't see an issue with this.
> This would only be
dhaumann accepted this revision.
dhaumann added a comment.
I also think it's fine. A next patch could convert the QRegExp to a
QRegularExpression.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D24403
To: aacid, cullmann, dhaumann
Cc: dhaumann, cullmann, kwrite-d
cullmann accepted this revision.
cullmann added a comment.
I think this is ok to merge, I don't see the issue with the QRegExp. (I
understand that it stores it result in mutable data in the object, but that
patch didn't alter this, just avoids the copying of the regex before this
happens, or
aacid planned changes to this revision.
aacid added inline comments.
INLINE COMMENTS
> modebase.cpp:333
> -
> -QRegExp endOfWORD(endOfWORDPattern);
>
This is wrong, QRegExp is broken and lastIndexIn modifies the object even if
the function is marked as const
REPOSITORY
R39 KTextEditor
aacid created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
aacid requested review of this revision.
REVISION SUMMARY
As far as i can see none of the modified .h files is actually public so
that shouldn't be a BC problem
