This revision was automatically updated to reflect the committed changes.
ahmadsamir marked an inline comment as done.
Closed by commit R241:54ccb1ac4883: More fixes to compile without implicit
conversion from ASCII/ByteArray (authored by ahmadsamir).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPD
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
arcpatch-D24349 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D24349
To: ahmadsamir, dfaure, #frameworks
Cc: yurchor, kde-frameworks-devel, LeGast00n, GB_2, mich
ahmadsamir updated this revision to Diff 70407.
ahmadsamir added a comment.
Per dfaure's recommendation, change createSystemBookmark 2nd and 3rd params
to take a const char * (since this is the translation context which will be
dropped) and a QByteArray, respectively.
REPOSITORY
R241 KIO
dfaure added inline comments.
INLINE COMMENTS
> kfileplacesmodel.cpp:280
> KFilePlacesItem::createSystemBookmark(d->bookmarkManager,
> - I18NC_NOOP("KFile System
> Bookmarks", "Home"),
> +
> I18NC
ahmadsamir added inline comments.
INLINE COMMENTS
> yurchor wrote in kfileplacesmodel.cpp:275
> This does not work. Our translation system cannot extract from something like
>
> I18NC_NOOP(fsBookmarks, QStringLiteral("Desktop"))
>
> all the strings below with I18NC_NOOP should be left as is. Th
ahmadsamir updated this revision to Diff 70379.
ahmadsamir marked 5 inline comments as done.
ahmadsamir added a comment.
- Keep I18NC_NOOP working
- QLatin1String where appropriate
- Rename mProtocolToStr() to protocolName(), and make it private (only used
in slavebase)
REPOSITORY
R241
dfaure added inline comments.
INLINE COMMENTS
> yurchor wrote in kfileplacesmodel.cpp:275
> This does not work. Our translation system cannot extract from something like
>
> I18NC_NOOP(fsBookmarks, QStringLiteral("Desktop"))
>
> all the strings below with I18NC_NOOP should be left as is. Thanks
yurchor added inline comments.
INLINE COMMENTS
> dfaure wrote in kfileplacesmodel.cpp:275
> This is more commonly written as "static const"
This does not work. Our translation system cannot extract from something like
I18NC_NOOP(fsBookmarks, QStringLiteral("Desktop"))
all the strings below wit
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ahmadsamir wrote in slavebase.h:979
> A B C, nothing changed inside make it const, D E F.
Yep ;)
Hmm, also it's in the middle of member variables, better not
ahmadsamir added a comment.
Ping. (I want to get this committed to close the gates before any more
implicit conversions sneak in :)).
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24349
To: ahmadsamir, dfaure, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, mic
ahmadsamir updated this revision to Diff 70271.
ahmadsamir marked 8 inline comments as done.
ahmadsamir retitled this revision from "More (and last) fixes to compile
without implicit conversion from ASCII/ByteArray" to "More fixes to compile
without implicit conversion from ASCII/ByteArray".
ahma
ahmadsamir added inline comments.
INLINE COMMENTS
> dfaure wrote in slavebase.h:979
> This method should be const
A B C, nothing changed inside make it const, D E F.
> dfaure wrote in ftp.cpp:1232
> Should this be remoteEncoding()->decode(...) given that the method will then
> use q->remoteEnc
12 matches
Mail list logo
