This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3b98d91436f5: [DataProtocol] compile without implicit
coversion from ascii (authored by ahmadsamir).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24308?vs=67125&id=67
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
ahmad/compile-without-ascii-cast (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D24308
To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,
ahmadsamir updated this revision to Diff 67125.
ahmadsamir added a comment.
Make it faster by comparing char's directly
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24308?vs=67062&id=67125
BRANCH
ahmad/compile-without-ascii-cast (branched from master)
REV
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> dataprotocol.cpp:120
> {
> -int size = buf.length();
> -while (pos < size && buf[pos].isSpace()) {
> +const QString &str = QString::fromLatin1(buf
ahmadsamir created this revision.
ahmadsamir added a reviewer: dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
TEST PLAN
make && ctest
REPOSITORY
R241 KIO
BRANCH
ahmad/compile-without-ascii-cast (branched from master)
REVISION DETAIL
https://pha
