nibags added a comment.
In the function `KateModeMenuList::updateSelectedItem()` an empty QIcon is
also created when selecting an item. It would be better to put `emptyIcon` as
an attribute of the class and use it every time.
I will do it in another commit, I have seen others bugs in the
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:8cb82970b347: Status bar mode menu: Reuse empty QIcon that
is implicitly shared (authored by dhaumann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24166?vs=66
cullmann accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R39 KTextEditor
BRANCH
use-qicon-implicitly-shared
REVISION DETAIL
https://phabricator.kde.org/D24166
To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michae
dhaumann created this revision.
dhaumann added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.
REVISION SUMMARY
Instead of creating N empty QIcons, use just one QIcon
that i
