D23904: Add QIcon setters for the password dialogs

2019-09-13 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R236:001335535dae: Add QIcon setters for the password dialogs (authored by vkrause). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23904?vs=65966&id=65978 REVIS

D23904: Add QIcon setters for the password dialogs

2019-09-13 Thread Volker Krause
vkrause updated this revision to Diff 65966. vkrause added a comment. Fix typos. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23904?vs=65948&id=65966 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23904 AFFECTED FILES src/knewp

D23904: Add QIcon setters for the password dialogs

2019-09-13 Thread David Faure
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > knewpassworddialog.h:97 > +/** > + * Sets the icon that appears next to the prompt in the dialog. The > default icon represent a simple key. > + * @since 5

D23904: Add QIcon setters for the password dialogs

2019-09-12 Thread Volker Krause
vkrause updated this revision to Diff 65948. vkrause added a comment. Add icon() getter, deprecated pixmap methods, remove on demand pixmap label creation as we set an icon unconditionally. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23904?vs=659

D23904: Add QIcon setters for the password dialogs

2019-09-12 Thread Christoph Feck
cfeck added a comment. A getter would be nice. I am also fine with deprecating the pixmap calls. You can create an icon from a pixmap using QIcon. (Why is there no setIcon() in QLabel?) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D23904 To: vkrause, d

D23904: Add QIcon setters for the password dialogs

2019-09-12 Thread Volker Krause
vkrause added a task: T11637: Investigate if KIconThemes is needed as a framework. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D23904 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23904: Add QIcon setters for the password dialogs

2019-09-12 Thread Volker Krause
vkrause added a comment. Should we deprecate the pixmap methods in favor of the icon ones? Do we need an QIcon getter too? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D23904 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23904: Add QIcon setters for the password dialogs

2019-09-12 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This avoids having to pass in QPixmaps with a fixed size. REPOSITORY R236 KWidgetsA