This revision was automatically updated to reflect the committed changes.
Closed by commit R241:79ee43be4d3f: Split KSslErrorUiData from KTcpSocket
(authored by vkrause).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23825?vs=65731&id=65775
REVISION DETAIL
htt
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.
Other than that just commit it i'd say, you're just moving code around so no
need to "re-review" code that we already accept as "good" for the moment imho
REPOSITORY
R241 KIO
BRANCH
mast
aacid added inline comments.
INLINE COMMENTS
> ksslerroruidata.h:26
> +
> +template class QList;
> +class KTcpSocket;
Minor comment, with all the "noise" around QList in Qt6, would it be maybe more
future proof to just #include ehre so we don't end up declaring a class
that doesn't exist in
vkrause created this revision.
vkrause added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.
REVISION SUMMARY
The former we want to keep, the latter we want to deprecate, so this is
a necessary
