D23772: Make less use of deprecated enum alias NET::StaysOnTop

2019-09-07 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. kossebau marked an inline comment as done. Closed by commit R278:c747c71d7146: Make less use of deprecated enum alias NET::StaysOnTop (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23772?vs=6

D23772: Make less use of deprecated enum alias NET::StaysOnTop

2019-09-07 Thread Friedrich W. H. Kossebau
kossebau added a comment. @zzag: Thanks for review. Will land once KF 5.62 is branched this WE. INLINE COMMENTS > zzag wrote in netwininfotestwm.cpp:449 > We can remove this row now. Indeed, does the same test as the row above, good catch, Will remove then. REPOSITORY R278 KWindowSystem

D23772: Make less use of deprecated enum alias NET::StaysOnTop

2019-09-07 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > netwininfotestwm.cpp:449 > QTest::newRow("keepAbove")<< NET::States(NET::KeepAbove) > << (QVector() << keepAbove << staysOnTop); > -QTest::newRow("staysOnTop") << NET::States(NET::StaysOnTop) > << (QVector() << ke

D23772: Make less use of deprecated enum alias NET::StaysOnTop

2019-09-07 Thread Vlad Zagorodniy
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH lessuseofstaysOnTop REVISION DETAIL https://phabricator.kde.org/D23772 To: kossebau, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23772: Make less use of deprecated enum alias NET::StaysOnTop

2019-09-07 Thread Vlad Zagorodniy
zzag edited reviewers, added: KWin; removed: Frameworks. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D23772 To: kossebau, #kwin, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23772: Make less use of deprecated enum alias NET::StaysOnTop

2019-09-07 Thread Friedrich W. H. Kossebau
kossebau added a comment. Found while experimenting with code for T11490 . This patch would later allow to do a simple #if KWINDOWSYSTEM_ENABLE_DEPRECATED_SINCE(5, 0) /** @deprecated This is an obsolete name for Kee

D23772: Make less use of deprecated enum alias NET::StaysOnTop

2019-09-07 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY - use NET::KeepAbove instead of NET::StaysOnTop in code - deduplicate code ha