D23771: Improve API documentation for Definition::setKeywordList()

2019-09-07 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:5db5ac6dad3d: Improve API documentation for Definition::setKeywordList() (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23771?vs

D23771: Improve API documentation for Definition::setKeywordList()

2019-09-07 Thread Dominik Haumann
dhaumann added a comment. Thanks for the quick review! REPOSITORY R216 Syntax Highlighting BRANCH improve-docs REVISION DETAIL https://phabricator.kde.org/D23771 To: dhaumann, sirgienko Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demskin

D23771: Improve API documentation for Definition::setKeywordList()

2019-09-07 Thread Nikita Sirgienko
sirgienko accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH improve-docs REVISION DETAIL https://phabricator.kde.org/D23771 To: dhaumann, sirgienko Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,

D23771: Improve API documentation for Definition::setKeywordList()

2019-09-07 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > sirgienko wrote in definition.h:344 > > In general, ... in general > > Is it correct? Or just accidental typo? Of course not! Thanks! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23771 To: dhaumann, sir

D23771: Improve API documentation for Definition::setKeywordList()

2019-09-07 Thread Dominik Haumann
dhaumann updated this revision to Diff 65571. dhaumann added a comment. - Fix duplication of "in general" REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23771?vs=65570&id=65571 BRANCH improve-docs REVISION DETAIL https://phabricator.kde.or

D23771: Improve API documentation for Definition::setKeywordList()

2019-09-07 Thread Nikita Sirgienko
sirgienko added inline comments. INLINE COMMENTS > definition.h:344 > * > - * This function can be usefull for dynamic higlighting, when the > document rehiglights more, that one time. > - * For example, you have a program for editing and running Octave > scripts files and > -

D23771: Improve API documentation for Definition::setKeywordList()

2019-09-07 Thread Dominik Haumann
dhaumann created this revision. dhaumann added a reviewer: sirgienko. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Followup to D23061 . The