D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg

2019-09-06 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R240:67acfe3c9c46: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg (authored by kossebau). REPOSI

D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg

2019-09-06 Thread Friedrich W. H. Kossebau
kossebau added a comment. Given ECM 5.62 will be tagged this WE and thus the API of the new macro `ecm_qtdesignerplugin_widget` being frozen, and no-one really gave feedback on the initial API, would take the responsibility and push tonight, unless there is last minute discussion. Only users

D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg

2019-09-06 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 65514. kossebau added a comment. For convenience still enable CONSTRUCTOR_ARGS_CODE, usually simple string without ";" REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23725?vs=65396&id=65514 BRANCH crea

D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg

2019-09-04 Thread Friedrich W. H. Kossebau
kossebau added a dependent revision: D23726: Designer plugin: adapt to pre-release API change of ECMAddQtDesignerPlugin. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23725 To: kossebau, #frameworks, #build_system, vkrause Cc: kde-frameworks-devel, kde-bui

D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg

2019-09-04 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, Build System, vkrause. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The initial API asked to hav