This revision was automatically updated to reflect the committed changes.
Closed by commit R296:19bf8ad69bde: Warn if KPackage is invalid (authored by
broulik).
REPOSITORY
R296 KDeclarative
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23722?vs=65380&id=65567
REVISION DETAIL
http
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Let's consider it an iteration though.
INLINE COMMENTS
> broulik wrote in configmodule.cpp:174
> Is "mainscript" mandatory?
>
> In any case, if your package has the incorrect folder structure,
broulik added inline comments.
INLINE COMMENTS
> apol wrote in configmodule.cpp:174
> maybe put it after checking the mainscript? the "no QML file provided" error
> is more accurate. We can keep ::isValid as a fallback.
> Actually, if there's no mainscript it probably shouldn't be valid.
Is "m
apol added inline comments.
INLINE COMMENTS
> configmodule.cpp:174
> +
> if (!package.filePath("mainscript").isEmpty()) {
> d->_qmlObject->setSource(package.fileUrl("mainscript"));
maybe put it after checking the mainscript? the "no QML file provided" error
is more accurate. We c
ngraham added a comment.
+1 in concept. Is there any more verbose information we can get though? Like
specifically how the package is invalid?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D23722
To: broulik, mart, tcanabrava
Cc: ngraham, kde-frameworks-devel,
broulik created this revision.
broulik added reviewers: mart, tcanabrava.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
Previously it would warn about no "mainscript" having been provided but all
