This revision was automatically updated to reflect the committed changes.
Closed by commit R39:b9167245dd3d: buffer: Port away from foreach loops over
members without calls to owner (authored by kossebau).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2369
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Looks OK.
REPOSITORY
R39 KTextEditor
BRANCH
portawayfromforeachforitemconstructionestimation_buffer
REVISION DETAIL
https://phabricator.kde.org/D23697
To: kossebau, #kate, cullm
kossebau edited the summary of this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D23697
To: kossebau, #kate
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
kossebau added a comment.
Also candidate for post 5.62-tagging, for some weeks of testing in master.
Like all the following review requests. only the autotest one should be good to
go in before, not critical to users.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.or
kossebau created this revision.
kossebau added a reviewer: Kate.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.
REVISION SUMMARY
There is some small risk here:
- overseen call chains which st