D23694: Add support for sshfs to the fstab backend

lbeltrame closed this revision. lbeltrame added a comment. https://invent.kde.org/frameworks/solid/commit/a41ce6a27eb07096356acb3e03ecf69e9ca0173d REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc: elvisangelac

D23694: Add support for sshfs to the fstab backend

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc: elvisangelaccio, albertvaka, ngraham, kde-frameworks-devel, LeGast00

D23694: Add support for sshfs to the fstab backend

lbeltrame added a comment. Any objections? Or I'll merge on Sunday evening UTC+1. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc: elvisangelaccio, albertvaka, ngraham, kde-frameworks-devel, LeGast00n, cblack

D23694: Add support for sshfs to the fstab backend

elvisangelaccio added a comment. In D23694#676619 , @elvisangelaccio wrote: > In D23694#676610 , @lbeltrame wrote: > > > @elvisangelaccio Thanks, first of all. If that's the case, do you think it's

D23694: Add support for sshfs to the fstab backend

elvisangelaccio added a comment. In D23694#676610 , @lbeltrame wrote: > @elvisangelaccio Thanks, first of all. If that's the case, do you think it's better to touch KIO first before landing this? Yeah this should probably wait for the KI

D23694: Add support for sshfs to the fstab backend

lbeltrame added a comment. @elvisangelaccio Thanks, first of all. If that's the case, do you think it's better to touch KIO first before landing this? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc: elvisang

D23694: Add support for sshfs to the fstab backend

elvisangelaccio added a comment. In D23694#676607 , @lbeltrame wrote: > Would this change be needed on this side or kdeconnect side? I don't mind landing this, but I need formal approval by someone. (I won't have any time to do additional chang

D23694: Add support for sshfs to the fstab backend

bruns added a comment. One possibility to hide it would be the `x-gvfs-*` options, though I am not sure if it is possible to pass these to fuse. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc: elvisangelacci

D23694: Add support for sshfs to the fstab backend

lbeltrame added a comment. Would this change be needed on this side or kdeconnect side? I don't mind landing this, but I need formal approval by someone. (I won't have any time to do additional changes elsewhere). REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694

D23694: Add support for sshfs to the fstab backend

elvisangelaccio added a comment. Ping? Can we get this in? In D23694#525220 , @albertvaka wrote: > If it's a problem for kdeconnect mounts to appear there, how can we hide it? It's an sshfs mountpoint like any other, only that it is mounted

D23694: Add support for sshfs to the fstab backend

albertvaka added a comment. If it's a problem for kdeconnect mounts to appear there, how can we hide it? It's an sshfs mountpoint like any other, only that it is mounted programmatically. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, bro

D23694: Add support for sshfs to the fstab backend

ngraham added a comment. +1 for doing this and also fixing KDE Connect to not expose its mount as an implementation detail. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc: ngraham, kde-frameworks-devel, LeGa

D23694: Add support for sshfs to the fstab backend

broulik added a reviewer: KDE Connect. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694 To: lbeltrame, bruns, broulik, fvogt, #kde_connect Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23694: Add support for sshfs to the fstab backend

broulik added a comment. This causes KDE connect drive to show up as "/run/user/1000/HASH (fuse.sshfs)" in places panel while being accessed. I really don't like KDE connect using sshfs, though, so +1 from me :P REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D23694

D23694: Add support for sshfs to the fstab backend

lbeltrame added a comment. In D23694#524968 , @fvogt wrote: > `fuse.sshfs` is used by kdeconnect as well, does that cause some kind of conflict? I can't test this in the current network (no office wifi, broadcast blocked at all levels).

D23694: Add support for sshfs to the fstab backend

fvogt added a comment. `fuse.sshfs` is used by kdeconnect as well, does that cause some kind of conflict? If not, LGTM. Could be improved by adding other filesystems (curlftpfs?) as well and using something like `QStringList{"nfs", "nfs4", "smbfs", "cifs", "fuse.sshfs"}.contain

D23694: Add support for sshfs to the fstab backend

lbeltrame created this revision. lbeltrame added reviewers: bruns, broulik, fvogt. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. lbeltrame requested review of this revision. REVISION SUMMARY This commit introduces support for sshfs as network filesystem.