dhaumann added a comment.
Also did a review and it looks good to me, thanks!
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D23661
To: kossebau, #kate, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2,
domson, michaelh, ngraham
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2ee34748cdb8: Port away from Qt's foreach all loops
over method-local containers (authored by kossebau).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23661?vs=6
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Looks ok for me, thanks for taking care.
REPOSITORY
R39 KTextEditor
BRANCH
plainporttorangeloop
REVISION DETAIL
https://phabricator.kde.org/D23661
To: kossebau, #kate, cullmann
kossebau added a comment.
There are quite a lot of foreachs in ktexteditor, so IMHO it makes sense to
split up the porting in multiple commits, so in case of regressions one can
bisect in the overall changes a bit and then has fewer changes to reason about
where something might have been bro
kossebau created this revision.
kossebau added a reviewer: Kate.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
kossebau requested review of this revision.
REVISION SUMMARY
The simple porting, as those containers are not shared with anyone,
