This revision was automatically updated to reflect the committed changes.
Closed by commit R216:b7555d6a475a: Format class: add functions to know if XML
files set style attributes (authored by nibags, committed by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Thanks!!
REPOSITORY
R216 Syntax Highlighting
BRANCH
format-new-functions
REVISION DETAIL
https://phabricator.kde.org/D23515
To: nibags, #framework_syntax_highlighting, dhaumann,
cullmann added a comment.
Dominik, ok with this now, too? Or did I miss some name issues in the API?
(tried to read all lines for spelling mistakes :=)
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D23515
To: nibags, #framework_syntax_highlighting, dhau
cullmann accepted this revision.
cullmann added a comment.
Think this is fine now, thanks.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D23515
To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel
nibags updated this revision to Diff 65017.
nibags added a comment.
- Update function names
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23515?vs=64779&id=65017
BRANCH
format-new-functions
REVISION DETAIL
https://phabricator.kde.org/D235
dhaumann added a comment.
I believe you still need the hasTextColorOverride etc. hasTextColor is
different and matches from the meaning isBold etc.
Background: The styleOverrides are yet another concept: if the user changes a
color of a highlighting in the Highlighting Text Styles tab, t
nibags added a comment.
I also like `hasXXOverride()`.
In the case of **bold**, **italic**, **underline** and **strikeout**,
functions such as `hasXXOverride()` are needed, since they are boolean values
that can be turned off. But for the case **color**, **selectedColor**,
**backgroundC
dhaumann added a comment.
Yes, that is also fine with me, please do the changes and proceed.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D23515
To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-dev
cullmann added a comment.
As we have already members like
hasX
would it make sense to have
hasItalicOverride()
to be more consistent?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D23515
To: nibags, #framework_syntax_highlighting, dha
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
What I currently dislike is that `definitionHasXyz` implies the Definition
class has something, which is not correct, since it's about whether the Format
has an override. I wo
cullmann added a comment.
Shall we go with the definitionHasX style or change it?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D23515
To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, LeGast0
cullmann added a comment.
No idea if definitionhasBold or the other variants are better.
For the "PS: Another solution is to port all xml files to not use hard coded
colors. That's a lot of work, though.": I think to hardcode e.g.
bold/italic/... is actually not that bad in some cases. That
dhaumann added a comment.
I am thinking about whether ` overwritesBold()` , ... is better than
`definitionHasBold()`. Because the `Format` matches an `itemData` in xml. Or
even `boldHardcoded()`.
Any thoughts?
PS: Another solution is to port all xml files to not use hard coded color
nibags added a dependent revision: D23516: Fix for all themes: allow turn off
attributes in XML highlighting files.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D23515
To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause
Cc: kwrite-devel
nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann,
vkrause.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.
REVISION SUMMARY
The functions isBo
15 matches
Mail list logo
