ahmadsamir added a comment.
Digging around in git log I found: https://git.reviewboard.kde.org/r/127026/
But I think that's covered by the method in QInputControl, and ktexteditor
has a unit test for that; I'll see how it goes.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phab
cullmann added a comment.
That would fix btw. https://bugs.kde.org/show_bug.cgi?id=366424, too.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D23472
To: ahmadsamir, #ktexteditor, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson,
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
I think the proper fix is:
1. remove any filtering in typeChars().
2. implement a Qt like handling in the void
KateViewInternal::keyPressEvent(QKeyEvent *e) member.
cullmann added a comment.
I checked a bit what Qt does:
bool QInputControl::isAcceptableInput(const QKeyEvent *event) const
{
const QString text = event->text();
if (text.isEmpty())
return false;
const QChar c = text.at(0);
// Formatting characters su
cullmann added a comment.
This is a good idea.
But actually, is there any reason we filter out stuff at all?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D23472
To: ahmadsamir, #ktexteditor, dhaumann, cullmann
Cc: kde-frameworks-devel, kwrite-devel, LeGast00n,
ahmadsamir created this revision.
ahmadsamir added reviewers: KTextEditor, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
The typeChars() functions filters out non-printable characters, except for:
\t, \n, \r; add QCh
