D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. Disagreement doesn't always mean distrust. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To: ahmadsamir, #ktexteditor, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns

D23457: Port regex search to QRegularExpression

ahmadsamir updated this revision to Diff 71617. ahmadsamir added a comment. Address comments REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23457?vs=71178&id=71617 BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricat

D23457: Port regex search to QRegularExpression

dhaumann added a comment. In D23457#574846 , @ahmadsamir wrote: > Personally, I am not convinced replacing \s with [ \t], and deviating from PCRE default behaviour is a good idea in this case. That is not to be discussed, and Christoph t

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. Personally, I am not convinced replacing \s with [ \t], and deviating from PCRE default behaviour is a good idea in this case. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To: ahmadsamir, #ktexteditor, dhaumann, cullmann Cc: k

D23457: Port regex search to QRegularExpression

dhaumann added a comment. Was anything of the previously commented issues addressed? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To: ahmadsamir, #ktexteditor, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh,

D23457: Port regex search to QRegularExpression

ahmadsamir updated this revision to Diff 71178. ahmadsamir added a comment. clang-fromat the code in this diff REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23457?vs=71059&id=71178 BRANCH l-qregularexpression (branched from master) REVISION DETAIL

D23457: Port regex search to QRegularExpression

ahmadsamir updated this revision to Diff 71059. ahmadsamir added a comment. Rebase REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23457?vs=64618&id=71059 BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. In D23457#568067 , @dhaumann wrote: > Any news here? For starters, this needs to be rebased; I'll try and get to it soon. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To:

D23457: Port regex search to QRegularExpression

dhaumann added a comment. Any news here? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To: ahmadsamir, #ktexteditor, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dh

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. In D23457#519773 , @cullmann wrote: > In D23457#519217 , @ahmadsamir wrote: > > > Maybe they'll also see it as ktexteditor/kate using a regex engine that matches what the

D23457: Port regex search to QRegularExpression

cullmann added a comment. In D23457#519217 , @ahmadsamir wrote: > Maybe they'll also see it as ktexteditor/kate using a regex engine that matches what the abundance of online pcre docs say, and how other editors that use pcre behave? > > II

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. Maybe they'll also see it as ktexteditor/kate using a regex engine that matches what the abundance of online pcre docs say, and how other editors that use pcre behave? IIUC, '\s' was workedaround so as not to match a newline so that the search pattern wouldn'

D23457: Port regex search to QRegularExpression

cullmann added a comment. In D23457#519206 , @ahmadsamir wrote: > In D23457#519205 , @cullmann wrote: > > > Hi, without any further look at the code changes, I don't think an behavior change like "

D23457: Port regex search to QRegularExpression

ahmadsamir added a comment. In D23457#519205 , @cullmann wrote: > Hi, without any further look at the code changes, I don't think an behavior change like "\s can match a newline" is a good idea. > Or do I misunderstand that? It's exact

D23457: Port regex search to QRegularExpression

cullmann added a comment. Hi, without any further look at the code changes, I don't think an behavior change like "\s can match a newline" is a good idea. Or do I misunderstand that? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To: ahmadsamir, #ktexted

D23457: Port regex search to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, dhaumann, cullmann. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Do away with the kateregexp class; move isMultiLine() to kateregexpsearch - \s can match a ne