This revision was automatically updated to reflect the committed changes.
Closed by commit R216:8a50002871dc: Set the OpenSCAD indenter to C-style
instead of none. (authored by mickaelbo, committed by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricato
mickaelbo added a comment.
Yup,
Mickael Bosch
mickael.bo...@linux.com
Thanks,
REVISION DETAIL
https://phabricator.kde.org/D23447
To: mickaelbo, #framework_syntax_highlighting, cullmann
Cc: cullmann, ngraham, kwrite-devel, kde-frameworks-devel, julianstirling,
LeGast00n, GB_2, domson
cullmann added a comment.
Can you pass me name + mail address for the commit?
REVISION DETAIL
https://phabricator.kde.org/D23447
To: mickaelbo, #framework_syntax_highlighting, cullmann
Cc: cullmann, ngraham, kwrite-devel, kde-frameworks-devel, julianstirling,
LeGast00n, GB_2, domson, micha
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
I see, I missed that you did only change the indentation of the file, I
thought you did alter some highlighting rules, too ;)
REVISION DETAIL
https://phabricator.kde.org/D23447
To: m
mickaelbo added a comment.
Thank you for the "js way" to modify the indentation. I will have a look at
this tomorrow.
From what I see, the *.scad* files in the autotest directory are exclusively
related to hightlighting and folding, nothing is related to the indenter
expected behavior (
cullmann added a comment.
For the cstyle + additional keywords: at the moment there is no way to
"automatically propagate that", but one could alter the js code to use
different trigger words for different highlightings.
Btw., how do one see that this is nicer? Does the highlighting of t
ngraham added a comment.
+1, this is nicer.
REVISION DETAIL
https://phabricator.kde.org/D23447
To: mickaelbo, #framework_syntax_highlighting
Cc: ngraham, kwrite-devel, kde-frameworks-devel, julianstirling, LeGast00n,
GB_2, domson, michaelh, bruns, demsking, cullmann, sars, dhaumann
mickaelbo updated this revision to Diff 64607.
mickaelbo added a comment.
Set the section to 3D and few style changes.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23447?vs=64598&id=64607
REVISION DETAIL
https://phabricator.kde.org/D23447
AFFECTED FILES
data/syntax/openscad.x
mickaelbo created this revision.
mickaelbo added a reviewer: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mickaelbo requested review of this revision.
REVISION SUMMARY
OpenSCAD uses braces enclosed blocks, you can see e