This revision was automatically updated to reflect the committed changes.
Closed by commit R39:42e7714a0184: KTextEditor: Fix left border flicker when
switching between documents (authored by daandemeyer, committed by cullmann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://ph
cullmann added a comment.
Given we use setAttribute(Qt::WA_StaticContents); I think using this
additional attribute is fine.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D23373
To: daandemeyer, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-fr
daandemeyer added a comment.
According to the documentation they should both achieve the same effect.
However, `Qt::WA_OpaquePaintEvent` takes precedence if both are used.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D23373
To: daandemeyer, #ktexteditor, cullma
dhaumann added a comment.
Looks good. Still, can the same be achieved with setAutoFillBackground(false)?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D23373
To: daandemeyer, #ktexteditor, cullmann
Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktex
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
KateIconBorder::paintBorder seems to take care to paint the complete
background,
// Paint background over full width...
p.fillRect(lnX, y, w, h, iconBarColor);
>
cullmann added a comment.
Hmm, I thought one can enable that safely, if the widget paintEvent paints
the full background anyways itself.
I think that should be ok for the iconborder but must take a look myself
again ;=)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kd
daandemeyer created this revision.
daandemeyer added a reviewer: KTextEditor.
daandemeyer added a project: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
daandemeyer requested review of this revision.
REVISION SUMMARY
See https
