asturmlechner closed this revision.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D23229
To: asturmlechner, #frameworks, ltoscano
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad,
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna
ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.
(sorry, time off) thanks!
REPOSITORY
R238 KDocTools
BRANCH
kdeinstalldirs
REVISION DETAIL
https://phabricator.kde.org/D23229
To: asturmlechner, #frameworks, ltoscano
Cc: ltoscan
asturmlechner marked 2 inline comments as done.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D23229
To: asturmlechner, #frameworks
Cc: ltoscano, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad,
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna
asturmlechner updated this revision to Diff 63954.
asturmlechner added a comment.
Use deprecated variables as fallback if defined
REPOSITORY
R238 KDocTools
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23229?vs=63952&id=63954
BRANCH
kdeinstalldirs
REVISION DETAIL
https://ph
ltoscano added a comment.
I can't check now, but I think the case were "the deprecated variable is set,
but the new one is not, then the old one is used" should be considered.
INLINE COMMENTS
> KF5DocToolsMacros.cmake:236
> +if (NOT KDE_INSTALL_MANDIR)
> +set(KDE_INSTALL_MANDIR
asturmlechner added a reviewer: Frameworks.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D23229
To: asturmlechner, #frameworks
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas,
michaelh, ngraham, bruns, skadinna
asturmlechner created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
asturmlechner requested review of this revision.
REVISION SUMMARY
HTML_INSTALL_DIR -> KDE_INSTALL_DOCBUNDLEDIR
MAN_INSTALL_DIR -> KDE_INSTALL_
