D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

brute4s99 added a comment. landed it! F7262311: shufflefurtherparrot.gif REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks, broulik Cc: nicolasfella, ngraham, broulik, kde-frameworks-devel,

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

This revision was automatically updated to reflect the committed changes. Closed by commit R289:a9b61d5b0cb8: avoid duplicate notifications from showing up on Windows and remove whitespaces (authored by brute4s99). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23133?vs=63846&id=64122#toc

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

brute4s99 added a subscriber: nicolasfella. brute4s99 added a comment. In D23133#515156 , @ngraham wrote: > Just on Windows, or does this fix the problem on Linux too? that problem has been fixed by @nicolasfella on master of kdeconnect-kd

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

ngraham added a comment. Just on Windows, or does this fix the problem on Linux too? REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks, broulik Cc: ngraham, broulik, kde-frameworks-devel, LeGast00n, GB_2, michael

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

brute4s99 added a comment. can I merge this one? 👀 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

brute4s99 updated this revision to Diff 63846. brute4s99 added a comment. took inspiration from NotifyByAndroid. Now I can see all types of notifications perfectly well! REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23133?vs=63674&id=63846 BRANCH

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

broulik added a comment. Then please investigate what's going on there. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

brute4s99 added a comment. the duplicate notification always has id= -1, so I think it's more an issue of KNotifications, I think REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, m

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

broulik added a comment. I think this is a bug in KDE Connect? I've seen numerous people complain about that in the new notification system that didn't filter them out originally. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #framewor

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

brute4s99 created this revision. brute4s99 added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY without this patch, most notifications show every notification twice. This