D22968: Make it possible to modify contacts

apol abandoned this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22968: Make it possible to modify contacts

apol added a comment. Committed as https://commits.kde.org/kpeople/7cf00a2cb27dcc11c8cd5b06423ce69c41537c82. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D22968: Make it possible to modify contacts

jbbgameich accepted this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22968: Make it possible to modify contacts

apol marked an inline comment as done. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22968: Make it possible to modify contacts

apol updated this revision to Diff 64963. apol added a comment. Don't get creative naming classes on the qml plugin REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22968?vs=64834&id=64963 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22968

D22968: Make it possible to modify contacts

jbbgameich added inline comments. INLINE COMMENTS > peopleqmlplugin.cpp:64 > qmlRegisterUncreatableType(uri, 1, 0, "ActionType", > QStringLiteral("You cannot create ActionType")); > +qmlRegisterSingletonType(uri, 1, 0, > "Manager", [] (QQmlEngine*, QJSEngine*) -> QObject* { return new

D22968: Make it possible to modify contacts

apol updated this revision to Diff 64834. apol added a comment. Address Bhushan's comments REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22968?vs=64325&id=64834 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22968 AFFECTED FILES src/ba

D22968: Make it possible to modify contacts

apol marked 3 inline comments as done. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22968: Make it possible to modify contacts

bshah requested changes to this revision. bshah added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > abstracteditablecontact.h:31 > + * > + * @since 5.60 > + * @internal Since 5.62 > persondata.h:103 > > +Q_SCRIPTABLE bool setContactCustomProperty(const

D22968: Make it possible to modify contacts

apol updated this revision to Diff 64325. apol added a comment. Fix JBB's crash REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22968?vs=64314&id=64325 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22968 AFFECTED FILES src/backends/CMak

D22968: Make it possible to modify contacts

apol updated this revision to Diff 64314. apol added a comment. Make it possible to create new contacts REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22968?vs=63191&id=64314 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22968 AFFECTED F

D22968: Make it possible to modify contacts

apol added a dependent revision: D22969: Make it possible to modify vcards. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22968: Make it possible to modify contacts

apol created this revision. apol added reviewers: Frameworks, jbbgameich, bshah. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Includes a vcard field so that backends can feed all of the data through