This revision was automatically updated to reflect the committed changes.
Closed by commit R309:99f21c7f7727: Fix KService build on Android (authored by
apol).
REPOSITORY
R309 KService
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22800?vs=62709&id=62786
REVISION DETAIL
https://p
vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.
Change looks fine to me, no opinion on the platform define style.
REPOSITORY
R309 KService
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22800
To: apol, #frameworks,
apol added inline comments.
INLINE COMMENTS
> broulik wrote in kbuildsycoca_main.cpp:26
> `Q_OS_ANDROID`?
Why?
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D22800
To: apol, #frameworks, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngrah
broulik added inline comments.
INLINE COMMENTS
> kbuildsycoca_main.cpp:26
> #include
> +#ifndef __ANDROID__
> #include
`Q_OS_ANDROID`?
REPOSITORY
R309 KService
REVISION DETAIL
https://phabricator.kde.org/D22800
To: apol, #frameworks, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n
apol created this revision.
apol added reviewers: Frameworks, sitter.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
DrKonqi isn't working there, so ifdef it out
TEST PLAN
Built it
REPOSITORY
R30
