D22647: Change Highlight to ButtonFocus in stylesheets

This revision was automatically updated to reflect the committed changes. Closed by commit R266:822b3ae3f88a: Change Highlight to ButtonFocus in stylesheets (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22647?vs=62303&id=62316 REVI

D22647: Change Highlight to ButtonFocus in stylesheets

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah, and that seems like a sensible practice in general. All right, ship it! REPOSITORY R266 Breeze Icons BRANCH focus-color (branched from master) REVISION DETAIL https://phabric

D22647: Change Highlight to ButtonFocus in stylesheets

ndavis added a comment. In D22647#500137 , @ngraham wrote: > Right, I see that there's actually no regression. In principle, can you describe what a color scheme needs to do to avoid this situation? Use a selection background color that i

D22647: Change Highlight to ButtonFocus in stylesheets

ngraham added a comment. Right, I see that there's actually no regression. In principle, can you describe what a color scheme needs to do to avoid this situation? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22647 To: ndavis, #vdg, ngraham Cc: ngraham, kde-f

D22647: Change Highlight to ButtonFocus in stylesheets

ndavis added a comment. In D22647#500117 , @ngraham wrote: > Whoa, huge diff. All the more reason why we need to find a way to have all the icons use a single external stylesheet. > > This will require documentation changes as well on https:

D22647: Change Highlight to ButtonFocus in stylesheets

ngraham requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22647 To: ndavis, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns

D22647: Change Highlight to ButtonFocus in stylesheets

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Whoa, huge diff. All the more reason why we need to find a way to have all the icons use a single external stylesheet. This will require documentation changes as well on https://hig.

D22647: Change Highlight to ButtonFocus in stylesheets

ndavis retitled this revision from "Change Highlight to ViewFocus in stylesheets" to "Change Highlight to ButtonFocus in stylesheets". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D22647 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, n