D22620: Add function to suggest a unique filename

2019-07-21 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R244:03b9bdee4f52: Add function to suggest a unique filename (authored by nicolasfella). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22620?vs=6&id=62223 REVI

D22620: Add function to suggest a unique filename

2019-07-21 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH suggestname REVISION DETAIL https://phabricator.kde.org/D22620 To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22620: Add function to suggest a unique filename

2019-07-21 Thread Nicolas Fella
nicolasfella updated this revision to Diff 6. nicolasfella added a comment. - Don't steal David's copyright - Remove TODO REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22620?vs=62218&id=6 BRANCH suggestname REVISION DETAIL https://phabr

D22620: Add function to suggest a unique filename

2019-07-21 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileutilstest.cpp:2 > +/* This file is part of the KDE libraries > +Copyright (c) 2019 Nicolas Fella > + Liar :-) I wrote the first version of this tes

D22620: Add function to suggest a unique filename

2019-07-21 Thread Nicolas Fella
nicolasfella updated this revision to Diff 62218. nicolasfella added a comment. - Add test REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22620?vs=62215&id=62218 BRANCH suggestname REVISION DETAIL https://phabricator.kde.org/D22620 AFFECTED FILES

D22620: Add function to suggest a unique filename

2019-07-21 Thread Nicolas Fella
nicolasfella edited the summary of this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D22620 To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22620: Add function to suggest a unique filename

2019-07-21 Thread David Faure
dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Please "move" (copy) the autotest as well, see kio/autotests/globaltest.cpp Typo in the commit log: s/it's/its/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabri

D22620: Add function to suggest a unique filename

2019-07-21 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This is a copy of KIO::suggestName. It doesn't use anything from KIO in