D22314: Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h

2019-07-07 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R273:071048e32a89: Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h (authored by arojas). REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22314?v

D22314: Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h

2019-07-07 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. In D22314#492011 , @dfaure wrote: > Makes sense to me - this is private API anyway - but that makes me wonder why Aleix added it explicitly in commit 0fe2990dbad992a4

D22314: Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h

2019-07-07 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Makes sense to me - this is private API anyway - but that makes me wonder why Aleix added it explicitly in commit 0fe2990dbad992a4

D22314: Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h

2019-07-07 Thread David Faure
dfaure added a reviewer: apol. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D22314 To: arojas, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22314: Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h

2019-07-07 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Since KF 5.60 kmodifierkeyinfoprovider_p.h depends on QSharedData, which is not wrapped