D22267: ContainmentAction: Fix loading from KPlugin

2019-07-05 Thread Friedrich W. H. Kossebau
kossebau added a comment. FTR now that all dep builds are updated, the plasma-frameworks part of the Plasma product also all passed, so all as it should. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22267 To: apol, #plasma, #frameworks, mart Cc

D22267: ContainmentAction: Fix loading from KPlugin

2019-07-05 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D22267#491236 , @kossebau wrote: > Hi. Seems CI is not happy about something here: https://build.kde.org/view/Failing/job/Plasma/job/plasma-framework/ please have a look. Ah, my had. This is the build variant

D22267: ContainmentAction: Fix loading from KPlugin

2019-07-05 Thread Friedrich W. H. Kossebau
kossebau added a comment. Hi. Seems CI is not happy about something here: https://build.kde.org/view/Failing/job/Plasma/job/plasma-framework/ please have a look. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22267 To: apol, #plasma, #frameworks

D22267: ContainmentAction: Fix loading from KPlugin

2019-07-04 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R242:46f0da45c655: ContainmentAction: Fix loading from KPlugin (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22267?vs=61136&id=61

D22267: ContainmentAction: Fix loading from KPlugin

2019-07-04 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D22267 To: apol, #plasma, #frameworks, mart Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22267: ContainmentAction: Fix loading from KPlugin

2019-07-04 Thread Aleix Pol Gonzalez
apol added a dependent revision: D22268: Port containmentActions to use KPlugin instead of KService. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22267 To: apol, #plasma, #frameworks Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22267: ContainmentAction: Fix loading from KPlugin

2019-07-04 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY At the moment it was enabled in the PluginLoader but we were not using it anywhere.