nibags closed this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D22253
To: nononux, nibags
Cc: nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
nibags accepted this revision.
nibags added a comment.
This revision is now accepted and ready to land.
That is complicated to do, we would have to make rules for all the columns
before 72 and for all the possible matchings, which is a lot of work and would
make the code difficult to maintain
nononux marked 2 inline comments as done.
nononux added a comment.
Thanks for the improvements propositions.
In the same way, I note the ">72th column" highlighting is not working when a
context start before the 72th column and goes after.
For example if a 2 digits number is placed on c
nononux updated this revision to Diff 61238.
nononux added a comment.
Update with nibags recommendations
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22253?vs=61110&id=61238
BRANCH
fortran-fixed-format (branched from master)
REVISION DETAI
nibags added a comment.
Now I checked the patch well and I want to add some final recommendations
before merging.
I think it's okay.
INLINE COMMENTS
> fortran-fixed.xml:368
> >
>
>
I recommend moving lines 374 and 375 (`` and ``)
to the beginning of the "defau
nononux marked an inline comment as done.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D22253
To: nononux
Cc: nibags, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars, dhaumann
nononux updated this revision to Diff 61110.
nononux added a comment.
Update of the version number + add the line proposed by nibags
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22253?vs=61103&id=61110
BRANCH
fortran-fixed-format (branched
nibags added a comment.
Only a small detail needs to be added. You also have to increase the version
of the file.
INLINE COMMENTS
> fortran-fixed.xml:557
> firstNonSpace="true"/>
> column="0"/>
>
Here add the rule: ``
In the previous fortran.xml file it was like
nononux created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nononux requested review of this revision.
REVISION SUMMARY
3 improvements:
- Restore the comment highlighting when using the "!" character (comment all
the
