D22250: get rid of blockSignals

2019-07-03 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R296:087be3e4f4be: get rid of blockSignals (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22250?vs=61096&id=61097 REVISION DETAIL https://phab

D22250: get rid of blockSignals

2019-07-03 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R296 KDeclarative BRANCH blocksignals REVISION DETAIL https://phabricator.kde.org/D22250 To: mart, #plasma, apol Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngr

D22250: get rid of blockSignals

2019-07-03 Thread Marco Martin
mart added a reviewer: Plasma. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D22250 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22250: get rid of blockSignals

2019-07-03 Thread Marco Martin
mart created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY Don't call blockSignals, but instead, to avoid an infinite signal chain, check KCoreConfigSkeleton::configChanged wasn't emi