This revision was automatically updated to reflect the committed changes.
Closed by commit R495:3d3af03052d0: Fix warning when reading plugin metadata
(authored by nicolasfella, committed by aacid).
REPOSITORY
R495 Purpose Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21967?
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Improving the string like Albert says could make sense. Also porting to
qCDebug. :)
REPOSITORY
R495 Purpose Library
BRANCH
warning
REVISION DETAIL
https://phabricator.kde.org/D21967
To
aacid added a comment.
Right, i see the point now, would make more sense to change the line to
qDebug() << "discarding" << meta.name() <<
obj.value(QStringLiteral("X-Purpose-PluginTypes")).toArray() << "doesn't
contain" << m_pluginType;
?
REPOSITORY
R495 Purpose Library
REVISI
nicolasfella added a comment.
It is the only place I found where KPluginMetaData.value is called on a list
REPOSITORY
R495 Purpose Library
REVISION DETAIL
https://phabricator.kde.org/D21967
To: nicolasfella, apol, aacid
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
aacid added a comment.
You only changed the debug line?
Doesn't feel like the right fix
REPOSITORY
R495 Purpose Library
REVISION DETAIL
https://phabricator.kde.org/D21967
To: nicolasfella, apol, aacid
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
nicolasfella updated this revision to Diff 60248.
nicolasfella edited the test plan for this revision.
nicolasfella added a comment.
- Whitespace
REPOSITORY
R495 Purpose Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21967?vs=60247&id=60248
BRANCH
warning
REVISION DETA
nicolasfella retitled this revision from "Fix warning when reading plugin
metadata
# NEW DIFFERENTIAL REVISION
# Describe the changes in this new revision.
#
# Included commits in branch warning:
#
# bcbf41157e8b Fix warning when reading plugin metadata
#
# arc could not identify..." to "F
nicolasfella created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
...any existing revision in your working copy.
1. If you intended to update an existing revision, use: #
