carewolf abandoned this revision.
carewolf added a comment.
Done independently
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D21604
To: carewolf, bruns, ngraham
Cc: alexeymin, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n,
cblack, fbampaloukas, GB_2,
bruns requested changes to this revision.
bruns added a comment.
This revision now requires changes to proceed.
This lacks a proper commit message
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D21604
To: carewolf, bruns, ngraham
Cc: alexeymin, kde-frameworks-devel, #b
carewolf added inline comments.
INLINE COMMENTS
> alexeymin wrote in regexpcache.cpp:81
> can probably just be `QString suffixMatch(QLatin1String("^.*\\.("));` then,
> without `=`
Sure, but it hardly matters, copy-elision will make the statements equivalent.
REPOSITORY
R293 Baloo
REVISION D
alexeymin added inline comments.
INLINE COMMENTS
> regexpcache.cpp:81
> // Combine all suffixes into one large RE: "^.*(foo|bar|baz)$"
> -auto suffixMatch = QLatin1String("^.*\\.(");
> +QString suffixMatch = QLatin1String("^.*\\.(");
> suffixMatch += suffixes.join(QChar('|'));
carewolf added reviewers: bruns, ngraham.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D21604
To: carewolf, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh,
astippich, spoorun, ngraham, bruns, abrahams
carewolf created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
carewolf requested review of this revision.
REPOSITORY
R293 Baloo
BRANCH
fix-build (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D21604
AFF
