D21574: Update KBruch icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:86d0782cf4e2: Update KBruch icon (authored by ognarb). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59187&id=59189 REVISION DETAIL https://phabric

D21574: Update KBruch icon

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH kbruch REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, mic

D21574: Update KBruch icon

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

ognarb updated this revision to Diff 59187. ognarb added a comment. - Optimize icon with scour-icon - Copy icon to breeze-dark - Remove png REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59131&id=59187 BRANCH kbruch REVISION DETAIL h

D21574: Update KBruch icon

ndavis added a comment. In D21574#474173 , @ognarb wrote: > Sorry it arc who also uploaded the png that I created for the review, I will fix it. Ah, fair enough. Easy mistake to make. REPOSITORY R266 Breeze Icons REVISION DETAIL htt

D21574: Update KBruch icon

ognarb added a comment. In D21574#474171 , @ndavis wrote: > Wait, is this a PNG? This needs to be just an SVG. We don't ship PNGs in breeze-icons. Sorry it arc who also uploaded the png that I created for the review, I will fix it. REPO

D21574: Update KBruch icon

ndavis added a comment. Once you're done with the SVG, make sure you clean it: https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#SVG_optimization REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc: ndavis, ngraham

D21574: Update KBruch icon

ndavis added a comment. Wait, is this a PNG? This needs to be an SVG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. There needs to be a copy in breeze dark as well. Nice job though! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg, ndavis Cc:

D21574: Update KBruch icon

ognarb updated this revision to Diff 59131. ognarb added a comment. Add shadow REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21574?vs=59123&id=59131 BRANCH kbruch REVISION DETAIL https://phabricator.kde.org/D21574 AFFECTED FILES icons/apps/48

D21574: Update KBruch icon

ngraham added a comment. Nice! A line of dark pixels on the bottom would help it fit the style even better too. See https://hig.kde.org/style/icon.html#shadows REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg Cc: ngraham, kde-frameworks-de

D21574: Update KBruch icon

ognarb edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

ognarb edited the test plan for this revision. ognarb added a reviewer: VDG. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D21574 To: ognarb, #vdg Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. REVISION SUMMARY Inspired from application-edu and cantor icon TEST PLAN Screenshot comming REPOSITORY R266 Breeze Icons BRANCH kb