D21411: YAML: only comments after spaces and other improvements/fixes

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21411 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D21411: YAML: only comments after spaces and other improvements/fixes

nibags added a comment. > Could one adapt the theme and remove the color later? Yes, it would be ideal, so there is consistency among all the themes REPOSITORY R216 Syntax Highlighting BRANCH improve-yaml REVISION DETAIL https://phabricator.kde.org/D21411 To: nibags, dhaumann, cu

D21411: YAML: only comments after spaces and other improvements/fixes

cullmann added a comment. Hmm, ok, anyways, this change looks ok =) Could one adapt the theme and remove the color later? REPOSITORY R216 Syntax Highlighting BRANCH improve-yaml REVISION DETAIL https://phabricator.kde.org/D21411 To: nibags, dhaumann, cullmann, #framework_syntax_hig

D21411: YAML: only comments after spaces and other improvements/fixes

nibags added a comment. > Btw., would it be possible to remove the hardcoded color here: That I added it in a previous commit; use hard background color to mark indentation with Tabs in some situations (specifically, in the indentation capture with dynamic rules), since YAML uses indent

D21411: YAML: only comments after spaces and other improvements/fixes

cullmann accepted this revision. cullmann added a comment. Screenshots look better! Btw., would it be possible to remove the hardcoded color here: REPOSITORY R216 Syntax Highlighting BRANCH improve-yaml REVISION DETAIL https://phabricator.kde.org/D21411 To: nibags, dhaumann, cul

D21411: YAML: only comments after spaces and other improvements/fixes

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting BRANCH improve-yaml REVISION DETAIL https://phabricator.kde.org/D21411 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns,

D21411: YAML: only comments after spaces and other improvements/fixes

nibags updated this revision to Diff 58936. nibags added a comment. - Some fixes in attributes and update test file REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21411?vs=58663&id=58936 BRANCH improve-yaml REVISION DETAIL https://phabrica

D21411: YAML: only comments after spaces and other improvements/fixes

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH improve-yaml REVISION DETAIL https://phabricator.kde.org/D21411 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel, kde-frameworks-deve

D21411: YAML: only comments after spaces and other improvements/fixes

nibags edited the summary of this revision. nibags added reviewers: dhaumann, cullmann, Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21411 To: nibags, dhaumann, cullmann, #framework_syntax_highlighting Cc: kwrite-devel, kde-

D21411: YAML: only comments after spaces and other improvements/fixes

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH improve-yaml REVISION DETAIL https://phabricator.kde.org/D21411 AFFECTE