D21401: Use native dialog overwrite check

ngraham added a comment. So nice! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21401 To: meven, ngraham, #frameworks, #kate, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D21401: Use native dialog overwrite check

This revision was automatically updated to reflect the committed changes. Closed by commit R39:fb2ea92822d2: Use native dialog overwrite check (authored by meven). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21401?vs=58708&id=58710 REVISION DETAIL htt

D21401: Use native dialog overwrite check

meven added a comment. Good part is that the overwrite check dialog will now be a native one analog to other apps instead of a KMessageBox, providing consistency outside of KDE. REPOSITORY R39 KTextEditor BRANCH arcpatch-D21401 REVISION DETAIL https://phabricator.kde.org/D21401 To: m

D21401: Use native dialog overwrite check

meven updated this revision to Diff 58708. meven added a comment. Remove decl of removed function checkOverwrite REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21401?vs=58646&id=58708 BRANCH arcpatch-D21401 REVISION DETAIL https://phabricator.kde.o

D21401: Use native dialog overwrite check

cullmann added a comment. I think this is fine then, please remove the decl. of bool KTextEditor::DocumentPrivate::checkOverwrite(QUrl u, QWidget *parent), too and push this, thanks! REPOSITORY R39 KTextEditor BRANCH native-overwrite-check REVISION DETAIL https://phabricator.kde.org/

D21401: Use native dialog overwrite check

meven added a comment. In D21401#470121 , @ngraham wrote: > This will work fine for a KDE environment where we know that the file dialog correctly handles the overwrite use case. Do we know that the GTK file dialog does the same for when Kate is

D21401: Use native dialog overwrite check

ngraham added a comment. This will work fine for a KDE environment where we know that the file dialog correctly handles the overwrite use case. Do we know that the GTK file dialog does the same for when Kate is run on GNOME, XFCE, or MATE? REPOSITORY R39 KTextEditor BRANCH native-overwr

D21401: Use native dialog overwrite check

cullmann added a comment. checkOverwrite decl. should be removed, too. REPOSITORY R39 KTextEditor BRANCH native-overwrite-check REVISION DETAIL https://phabricator.kde.org/D21401 To: meven, ngraham, #frameworks, #kate, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson,

D21401: Use native dialog overwrite check

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Sounds reasonable. REPOSITORY R39 KTextEditor BRANCH native-overwrite-check REVISION DETAIL https://phabricator.kde.org/D21401 To: meven, ngraham, #frameworks, #kate, cullmann C

D21401: Use native dialog overwrite check

meven added a task: T8552: Polish Open/Save dialogs. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21401 To: meven, ngraham, #frameworks, #kate Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D21401: Use native dialog overwrite check

meven created this revision. meven added reviewers: ngraham, Frameworks, Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. meven requested review of this revision. REVISION SUMMARY Past review https://git.reviewboard.kde.org/r/128452/ av