aacid closed this revision.
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D21388
To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R243 KArchive
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21388
To: aacid, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
aacid added a comment.
test at https://phabricator.kde.org/D21390
Made it in two separate bits so you can:
a) cherry-pick the test, run it, see it fails
b) cherry-pick this fix on top, run test it, see it doesn't fail
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricato
apol added a comment.
How hard would it be to test this?
I like how the code ends up being much simpler.
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D21388
To: aacid
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.
REVISION SUMMARY
bIgnoreData was used in ::seek to say, we don't really care much
about the next readData call because we know it's coming
