D21328: Add qml import for KItemModels

This revision was automatically updated to reflect the committed changes. Closed by commit R275:adb9b0e9cd3a: Add qml import for KItemModels (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21328?vs=64882&id=69738#toc REPOSITORY R275 KItemModels CHANGES SIN

D21328: Add qml import for KItemModels

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Alright then, let's get this in and kossebau can port it eventually. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D21328 To: davidedmundson, apo

D21328: Add qml import for KItemModels

kossebau added a comment. In D21328#521535 , @davidedmundson wrote: > > Can you look into kossebau's coment? Let's get this in once that's ironed out. > > Kossebau's new API is not yet merged. It looks nice though. Yes, sorry, I drop

D21328: Add qml import for KItemModels

davidedmundson added a comment. > Can you look into kossebau's coment? Let's get this in once that's ironed out. Kossebau's new API is not yet merged. It looks nice though. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D21328 To: davidedmundson Cc: kosseba

D21328: Add qml import for KItemModels

apol added a comment. Can you look into kossebau's coment? Let's get this in once that's ironed out. INLINE COMMENTS > CMakeLists.txt:30 > > +if (${Qt5Qml_FOUND}) > +ecm_add_tests( I like `if (TARGET Qt5::Qml)` better. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricat

D21328: Add qml import for KItemModels

davidedmundson updated this revision to Diff 64882. davidedmundson added a comment. Add KDescendentsProxyModel REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21328?vs=64881&id=64882 BRANCH master REVISION DETAIL https://phabricator.kde.org/D21328

D21328: Add qml import for KItemModels

davidedmundson added a comment. > I wonder if it was necessary to do the whole move into core :P. It wasn't necessary, but I was trying to follow the framework convention. If it helps get this, I can remove it. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.or

D21328: Add qml import for KItemModels

davidedmundson updated this revision to Diff 64881. davidedmundson added a comment. Port manual test to unit test REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21328?vs=58449&id=64881 BRANCH master REVISION DETAIL https://phabricator.kde.org/D213

D21328: Add qml import for KItemModels

kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:12 > + > +install(TARGETS itemmodelsplugin DESTINATION > ${KDE_INSTALL_QMLDIR}/org/kde/kitemmodels) > +install(FILES qmldir DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/kitemmodels) With the macros of ECMAddQmlModule proposed in D209

D21328: Add qml import for KItemModels

vkrause added a comment. +1 too, having the QML bindings as part of the corresponding framework is IMHO the way to go, compared to the KDeclarative approach. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D21328 To: davidedmundson Cc: vkrause, apol, kde-framewor

D21328: Add qml import for KItemModels

apol added a comment. I wonder if it was necessary to do the whole move into core :P. +1 overall INLINE COMMENTS > concatenaterows.qml:5 > +ListView { > +model: KConcatenateRowsProxyModel { > +id: myModel can we turn this into an autotest? REPOSITORY R275 KItemModels REV

D21328: Add qml import for KItemModels

davidedmundson updated this revision to Diff 58449. davidedmundson added a comment. Sync copyright headers to existing style REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21328?vs=58448&id=58449 BRANCH davidedmundson/qmlify REVISION DETAIL https:

D21328: Add qml import for KItemModels

davidedmundson retitled this revision from "Move everything in src to a subdirectory" to "Add qml import for KItemModels". davidedmundson edited the summary of this revision. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D21328 To: davidedmundson Cc: kde-frameworks