D21327: Support installing multiple Samba packages

bruns added inline comments. INLINE COMMENTS > sambausershareplugin.cpp:43 > > // copied from kio/src/core/ksambashare.cpp, > KSambaSharePrivate::isSambaInstalled() > static bool isSambaInstalled() see here ^ `net` is not checked for at all, it just tries to execute it using `QProcess::st

D21327: Support installing multiple Samba packages

This revision was automatically updated to reflect the committed changes. Closed by commit R432:0b2e51981044: Support installing multiple Samba packages (authored by ngraham). REPOSITORY R432 File Sharing (Samba) integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21327?vs=584

D21327: Support installing multiple Samba packages

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I wouldn't have made it better :D REPOSITORY R432 File Sharing (Samba) integration BRANCH support-multiple-samba-packages (branched from master) REVISION DETAIL https://phabricator.kde.o

D21327: Support installing multiple Samba packages

ngraham marked an inline comment as done. REPOSITORY R432 File Sharing (Samba) integration REVISION DETAIL https://phabricator.kde.org/D21327 To: ngraham, apol, #frameworks Cc: bruns

D21327: Support installing multiple Samba packages

ngraham updated this revision to Diff 58484. ngraham added a comment. Make it work (Thanks @apol for contributing virtually all of this code) REPOSITORY R432 File Sharing (Samba) integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21327?vs=58445&id=58484 BRANCH support-m

D21327: Support installing multiple Samba packages

ngraham added a comment. In D21327#468390 , @bruns wrote: > There are two executables required two run the samba integration properly: > > - smbd > - net > > But this is actually an implementation detail of KSambaShare from KIOCore. W

D21327: Support installing multiple Samba packages

bruns added a comment. There are two executables required two run the samba integration properly: - smbd - net But this is actually an implementation detail of KSambaShare from KIOCore. Wouldn't it be better to query the required packages from KSambaShare instead? REPOSITORY R43

D21327: Support installing multiple Samba packages

apol added a comment. Hope this helps ^^' INLINE COMMENTS > sambausershareplugin.cpp:155 > SIGNAL(package(PackageKit::Transaction::Info,QString,QString)), > > SLOT(packageInstall(PackageKit::Transaction::Info,QString,QString))); > This is a bit weird now, because

D21327: Support installing multiple Samba packages

ngraham created this revision. ngraham added reviewers: apol, Frameworks. ngraham requested review of this revision. REVISION SUMMARY Some distros (such as Manjaro) require multiple packages to be installed before a working Samba stack is present. This patch adjusts the CMake packaging and Sa