D21315: Dolphin-style view modes in the file dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d3098ed7205a: Dolphin-style view modes in the file dialog (authored by meven). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21315?vs=58832&id=59032#toc REPOSITORY R241 KIO CHANGES SINCE L

D21315: Dolphin-style view modes in the file dialog

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D21315 REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham, #vdg Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

ngraham added a comment. 5.59 has been tagged, so I think this can land now. REPOSITORY R241 KIO BRANCH arcpatch-D21315 REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham, #vdg Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

meven added a comment. In D21315#471780 , @ngraham wrote: > We're a bit close to Frameworks 5.59 tagging (June 1st). For large patches like this, sometimes it's worth waiting for the next release to give it a month of testing rather than rushing

D21315: Dolphin-style view modes in the file dialog

ngraham added a comment. We're a bit close to Frameworks 5.59 tagging (June 1st). For large patches like this, sometimes it's worth waiting for the next release to give it a month of testing rather than rushing it in close to the deadline. I say let's wait until after tagging to land it, or

D21315: Dolphin-style view modes in the file dialog

meven added a comment. I have made a small code change. Should I wait for some more review before landing this ? REPOSITORY R241 KIO BRANCH arcpatch-D21315 REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham, #vdg Cc: abetts, anthonyfieroni, kde-fra

D21315: Dolphin-style view modes in the file dialog

meven updated this revision to Diff 58832. meven marked an inline comment as done. meven added a comment. Avoid using Toggle in view activation callback names REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21315?vs=58776&id=58832 BRANCH arcpatch-D21315 REVI

D21315: Dolphin-style view modes in the file dialog

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works perfectly and the code looks sensible! INLINE COMMENTS > meven wrote in kdiroperator.cpp:1955 > Well there are pretty much reusable already, their actions are available in > the ac

D21315: Dolphin-style view modes in the file dialog

abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham, #vdg Cc: abetts, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kdiroperator.cpp:1955 > Can we make them reusable, it should be in framework and then accessed in > Dolphin. Well there are pretty much reusable already, their actions are available in

D21315: Dolphin-style view modes in the file dialog

meven added a dependent revision: D21459: Always save view settings when switching from one view mode to another. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham, #vdg Cc: anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

meven updated this revision to Diff 58776. meven added a comment. Bad comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21315?vs=58775&id=58776 BRANCH arcpatch-D21315 REVISION DETAIL https://phabricator.kde.org/D21315 AFFECTED FILES src/filewidget

D21315: Dolphin-style view modes in the file dialog

meven updated this revision to Diff 58775. meven added a comment. Remove icon zoom settings change this belong to another review REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21315?vs=58774&id=58775 BRANCH arcpatch-D21315 REVISION DETAIL https://phabrica

D21315: Dolphin-style view modes in the file dialog

meven updated this revision to Diff 58774. meven added a comment. Allow to save different zoom settings for all view kinds REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21315?vs=58642&id=58774 BRANCH arcpatch-D21315 REVISION DETAIL https://phabricator.kd

D21315: Dolphin-style view modes in the file dialog

anthonyfieroni added inline comments. INLINE COMMENTS > kdiroperator.cpp:1955 > > +// View modes that match those of Dolphin > +KToggleAction *iconsViewAction = new KToggleAction(i18n("Icons View"), > this); Can we make them reusable, it should be in framework and then accessed in Do

D21315: Dolphin-style view modes in the file dialog

meven added a reviewer: VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

meven added a comment. ANy REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

meven updated this revision to Diff 58642. meven added a comment. Fix missing ')' REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21315?vs=58424&id=58642 BRANCH dolphin-view-modes REVISION DETAIL https://phabricator.kde.org/D21315 AFFECTED FILES src/fil

D21315: Dolphin-style view modes in the file dialog

meven marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

meven updated this revision to Diff 58424. meven added a comment. Reword Allow Expansion to Allow Expansion in Details View REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21315?vs=58395&id=58424 BRANCH dolphin-view-modes REVISION DETAIL https://phabricato

D21315: Dolphin-style view modes in the file dialog

ngraham added a comment. This is fantastic. You fixed all the issues I was having, and the UX is practically perfect. The code looks totally sane too. In my testing I found only one small issue: when changing the icon size in one view and then switching to another view and then back, the fir

D21315: Dolphin-style view modes in the file dialog

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21315 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21315: Dolphin-style view modes in the file dialog

meven created this revision. meven added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Add Icons, Compact and Details view to the filewidgets. Added an "Allow Exp