D21313: Create specific directory for kdebugsettings categories file

mlaurent updated this revision to Diff 58952. mlaurent added a comment. Fix typo REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21313?vs=58746&id=58952 BRANCH add_specific_kdebugsetting_directory REVISION DETAIL https://phabricator.kde.org

D21313: Create specific directory for kdebugsettings categories file

cgiboudeaux added a comment. Maybe also update the commit message to 'Create specific directory for Qt logging categories file' REPOSITORY R240 Extra CMake Modules BRANCH add_specific_kdebugsetting_directory REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure, cgi

D21313: Create specific directory for kdebugsettings categories file

cgiboudeaux accepted this revision. cgiboudeaux added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > KDEInstallDirs.cmake:132 > +# ``LOGGINGCATEGORIESDIR`` > +# qt logging categories files directory > (``DATAROOTDIR/qlogging-categories5``) Since 5.59.0 >

D21313: Create specific directory for kdebugsettings categories file

mlaurent added a comment. So ? :) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure, cgiboudeaux Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

mlaurent updated this revision to Diff 58746. mlaurent added a comment. Change as qlogging-categories5 REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21313?vs=58604&id=58746 BRANCH add_specific_kdebugsetting_directory REVISION DETAIL https

D21313: Create specific directory for kdebugsettings categories file

mlaurent added a comment. Thanks david. Indeed qlogging-categories5 seems a good name :) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure, cgiboudeaux Cc: kossebau, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, n

D21313: Create specific directory for kdebugsettings categories file

dfaure added a comment. My suggestion is to call this qlogging-categories5. The 'q' prefix is missing to make this qt-specific rather than cross-toolkit. The "logging" instead of "debug" is because this affects all types of messages, and this is all about what's called "logging categori

D21313: Create specific directory for kdebugsettings categories file

mlaurent added a comment. LOGGINGCATEGORIESDIR indeed it's more specific +1 for me debug-categories5 => indeed it's just using by kdebugsettings at the moment. => kdebugsettings-categories5 ? no idea if it's better. @dfaure do you have an idea ?:) REPOSITORY R240 Extra CMake Modul

D21313: Create specific directory for kdebugsettings categories file

kossebau added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:131 > # autostart files (``CONFDIR/autostart``) [``AUTOSTART_INSTALL_DIR``] > +# ``DEBUGCATEGORIESDIR`` > +# kdebugsettings categories files directory > (``DATAROOTDIR/debug-categories5``) Since 5.59.0 Might `LOGGIN

D21313: Create specific directory for kdebugsettings categories file

mlaurent updated this revision to Diff 58604. mlaurent added a comment. Oops indeed I forgot to readd KXMLGUI_INSTALL_DIR Thanks for pointing me it :) REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21313?vs=58454&id=58604 BRANCH add_spec

D21313: Create specific directory for kdebugsettings categories file

cgiboudeaux added a comment. In D21313#469311 , @mlaurent wrote: > Ping ? You didn't add "KXMLGUI_INSTALL_DIR)" back to where it belongs afaics. If noone has a better suggestion, we'll go for debug-categories5 REPOSITORY R240 Extra

D21313: Create specific directory for kdebugsettings categories file

mlaurent added a comment. Ping ? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

mlaurent updated this revision to Diff 58454. mlaurent added a comment. Use DEBUGCATEGORIESDIR and debug-categories5 REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21313?vs=58391&id=58454 BRANCH add_specific_kdebugsetting_directory REVISION

D21313: Create specific directory for kdebugsettings categories file

mlaurent added a comment. DEBUGCATEGORIESDIR is fine for me too debug-categories5 ? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

cgiboudeaux added a comment. Looks mostly fine safe for the directory name that needs the major version to avoid conflicts when libfoo.categories built using KF5 will have to coexist with KF6. It needs a '5' in its name. I'm also unsure about 'KDEBUGSETTINGSDIR'. kdebugsettings is the

D21313: Create specific directory for kdebugsettings categories file

cgiboudeaux added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:583 > _define_relative(KXMLGUI5DIR DATAROOTDIR "kxmlgui5" > "kxmlgui .rc files" > _define_relative(KTEMPLATESDIR DATAROOTDIR "kdevappwizard/templates" KXMLGUI_INSTALL_DIR) came from this line :) REPOSITORY R240 E

D21313: Create specific directory for kdebugsettings categories file

mlaurent updated this revision to Diff 58391. mlaurent added a comment. Fix comment reported by Christophe Giboudeaux REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21313?vs=58390&id=58391 BRANCH add_specific_kdebugsetting_directory REVISION

D21313: Create specific directory for kdebugsettings categories file

cgiboudeaux added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:132 > +# ``KDEBUGSETTINGSDIR`` > +# kdebugsettings categories files directory > (``DATAROOTDIR/debug-categories``) > # # kdebugsettings categories files directory (``DATAROOTDIR/debug-categories``) Since 5.59.0.

D21313: Create specific directory for kdebugsettings categories file

mlaurent updated this revision to Diff 58390. mlaurent added a comment. Forgot to commit before creating diff REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21313?vs=58389&id=58390 BRANCH add_specific_kdebugsetting_directory REVISION DETAIL

D21313: Create specific directory for kdebugsettings categories file

lbeltrame removed a subscriber: cgiboudeaux. lbeltrame added a reviewer: cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure, cgiboudeaux Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

lbeltrame added a subscriber: cgiboudeaux. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

mlaurent added a reviewer: dfaure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21313 To: mlaurent, dfaure Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

mlaurent created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY kdebugsettings categories files REPOSITORY R240 Extra CMake Modules BRANCH add_spec