D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven abandoned this revision. meven added a comment. Thanks I'd be happy to take over. Some of the changes I did seem to me nice to have like moving class kdiroperatoriconview out of kdiroperator.cpp file and I am thinking about doing it again. REPOSITORY R241 KIO REVISION DETAIL htt

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Nathaniel Graham
ngraham added a comment. I was working on this myself last month by implementing new modes that are an amalgamation of existing settings, so nobody gets broken and backwards compatibility is ensured. I gotpretty far, but I hit a frustrating wall and forgot about it. :/ Your work here reminde

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven added a comment. This patch seems to me now inappropriate given the history of D12358 and D12326 . I only see a possibility in having Icons View and Compact view as Dolphin has without changing behavior and b

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven updated this revision to Diff 58337. meven added a comment. Clean up REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21283?vs=58336&id=58337 BRANCH icon-compact-views REVISION DETAIL https://phabricator.kde.org/D21283 AFFECTED FILES src/filewidget

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21283 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven updated this revision to Diff 58336. meven added a comment. Keep DetailTree as default file view REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21283?vs=58334&id=58336 BRANCH icon-compact-views REVISION DETAIL https://phabricator.kde.org/D21283 AFF

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven updated this revision to Diff 58334. meven added a comment. Extract KDirOperatorIconView to its own class REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21283?vs=58333&id=58334 BRANCH icon-compact-views REVISION DETAIL https://phabricator.kde.org/D2

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-20 Thread Méven Car
meven updated this revision to Diff 58333. meven added a comment. Reword Icon View to Icons View REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21283?vs=58303&id=58333 BRANCH icon-compact-views REVISION DETAIL https://phabricator.kde.org/D21283 AFFECTED

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-19 Thread Méven Car
meven updated this revision to Diff 58303. meven added a comment. Clean up reference to action decoration menu REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21283?vs=58280&id=58303 BRANCH icon-compact-views REVISION DETAIL https://phabricator.kde.org/D21

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-19 Thread Méven Car
meven updated this revision to Diff 58280. meven added a comment. Rename IconView kind Simple to Icon REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21283?vs=58279&id=58280 BRANCH icon-compact-views REVISION DETAIL https://phabricator.kde.org/D21283 AFFE

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-19 Thread Méven Car
meven updated this revision to Diff 58279. meven added a comment. Capitalization REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21283?vs=58277&id=58279 BRANCH icon-compact-views REVISION DETAIL https://phabricator.kde.org/D21283 AFFECTED FILES src/file

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-19 Thread Méven Car
meven edited the summary of this revision. meven edited the test plan for this revision. meven added a reviewer: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21283 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21283: Replace Simple View and Tree view by an icon view and compact view

2019-05-19 Thread Méven Car
meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Remove the simple view with the decoration position option, splitting the feature betwe