steffenh updated this revision to Diff 58241.
steffenh added a comment.
change name to KTouchGesture
add a private class for every exported class
remove unused code
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21028?vs=57584&id=58241
BRANCH
ngraham added a comment.
Since these are touch-only, maybe `KTouchGesture` or `KTouchHandler`?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D21028
To: steffenh, #frameworks
Cc: ngraham, apol, nicolasfella, cfeck, kde-frameworks-devel, michaelh, bruns
steffenh added a comment.
Hi @ngraham,
thanks for the link, I see KGesture is already used. I hope KGestureHandler
is not too similar
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D21028
To: steffenh, #frameworks
Cc: ngraham, apol, nicolasfella, cfeck,
ngraham added a comment.
Here's a tip: you can use https://lxr.kde.org to search for existing class
names and identifiers.
https://lxr.kde.org/search?_filestring=kgesture&_string=
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D21028
To: steffenh, #frame
steffenh added a comment.
Hi @nicolasfella,
Ok, I need a new name, perhaps KGesture ?
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D21028
To: steffenh, #frameworks
Cc: apol, nicolasfella, cfeck, kde-frameworks-devel, michaelh, ngraham, bruns
steffenh added a comment.
Hi @apol,
Thanks for your time to look at my code. I know, I'am not good at this, so if
you can point me at my errors I will try to correct this.
INLINE COMMENTS
> apol wrote in koneandtwofingerswipe.h:36
> Why is this commented out?
Oops this should not be he
apol added a comment.
It could make sense to run clazy on these, I'm pretty sure we'd find
interesting stuff.
INLINE COMMENTS
> koneandtwofingerswipe.h:36
> +{
> +//Q_PROPERTY(bool left READ left WRITE left)
> +//Q_PROPERTY(bool right READ right WRITE right)
Why is this commented ou
nicolasfella added a comment.
The name "KTouch" is already used for
https://kde.org/applications/education/ktouch/
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D21028
To: steffenh, #frameworks
Cc: nicolasfella, cfeck, kde-frameworks-devel, michaelh, ngraham
ngraham added a reviewer: Frameworks.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D21028
To: steffenh, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns
cfeck added a comment.
Did you try to submit the additional gesture types to Qt? We should only add
them here if they rejected the idea to add new types in Qt.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D21028
To: steffenh
Cc: cfeck, kde-frameworks-devel,
steffenh created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
steffenh requested review of this revision.
REVISION SUMMARY
This patch adds the gestures and handler class from gwenview to
KWidgetsAddons, so another program you can use this.
11 matches
Mail list logo
