D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau updated this revision to Diff 58490. kossebau added a comment. Renamed to ECMAddQmlModule, with more helper macros for non-C++ parts REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20984?vs=57481&id=58490 BRANCH addinstallqmlplugin R

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau updated this revision to Diff 57481. kossebau added a comment. Add also support for TYPEINFO, merging main logic of ecm_generate_qmltypes This allows e.g. to replace install(TARGETS platformcomponentsplugin DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/plasma/platformcomponent

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau updated this revision to Diff 57459. kossebau added a comment. get rid of newer list(TRANSFORM) REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20984?vs=57457&id=57459 BRANCH addinstallqmlplugin REVISION DETAIL https://phabricator.

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau updated this revision to Diff 57457. kossebau added a comment. Use file(WRITE/APPEND) over file(GENERATE), for less intermediate vars REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20984?vs=57450&id=57457 BRANCH addinstallqmlplugin

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau added a comment. In D20984#460128 , @apol wrote: > wouldn't it be almost as complex to `file(WRITE ... qmldir)`? Most of the code is to construct the file. You mean, replace `file(GENERATE` with `file(WRITE ... qmldir)`? Might be

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

apol added a comment. wouldn't it be almost as complex to `file(WRITE ... qmldir)`? Most of the code is to construct the file. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20984 To: kossebau, #plasma Cc: apol, kde-frameworks-devel, kde-buildsystem, be

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau updated this revision to Diff 57450. kossebau added a comment. Add DEPENDS & DESIGNERSUPPORTED, nothing complicated there (besides going for asking string with pair of identifier & version, to avoid any arg clash & make parsing easier) REPOSITORY R240 Extra CMake Modules CHANGE

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20984 To: kossebau, #plasma Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau added a comment. Possibly the ECMGenerateQmlTypes could be also merged somehow, but I have no experience with that, so leaving to someone else to improve here. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https:/

D20984: Add ECMInstallQmlModules, with ecm_install_qmlplugin as start

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Having to maintain and sync the module identifier in m