hallas closed this revision.
REPOSITORY
R294 KBookmarks
REVISION DETAIL
https://phabricator.kde.org/D20860
To: hallas, dfaure, aacid, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R294 KBookmarks
BRANCH
fix_kboomarkmenutest_without_bookmarks_editor (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D20860
To: hallas, dfaure, aacid, ngraham
Cc: kde-frameworks-d
hallas updated this revision to Diff 57100.
hallas marked 4 inline comments as done.
hallas added a comment.
Make the global functions static.
REPOSITORY
R294 KBookmarks
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20860?vs=57084&id=57100
BRANCH
fix_kboomarkmenutest_without_b
hallas marked an inline comment as not done.
REPOSITORY
R294 KBookmarks
REVISION DETAIL
https://phabricator.kde.org/D20860
To: hallas, dfaure, aacid, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
dfaure added a comment.
Thanks for the debugging. Looks good, just minor coding style issues.
INLINE COMMENTS
> kbookmarkmenutest.cpp:42
>
> +bool hasBookmarkEditorInstalled()
> +{
prepend static (good practice in general so the symbol isn't exported, although
in a test program it doesn't
hallas created this revision.
hallas added reviewers: dfaure, aacid, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hallas requested review of this revision.
REVISION SUMMARY
Fix KBoomarkMenuTest when Bookmarks Editor is not installed. The test
de
